The issue here is described in vimeo/psalm#3640

Thank you for working on this.

Integrated tests are failing:

-e ✘psalm-plugin-doctrine
777
Makefile:32: recipe for target 'test-integration' failed

@jakzal I know, the psalm-plugin tool (which I'd like to use to confirm Psalm can actually find the plugins) currently doesn't work without a config file, it's in the linked issue.

Fixed the underlying issue in vimeo/psalm#4639, but in the meantime Psalm 4 came out and plugins haven't caught up yet:
psalm/psalm-plugin-doctrine#78

@dkarlovi could this issue be related? jakzal/phpqa#263

@jakzal in what way, since this isn't yet merged? 🤔 Or am I misunderstanding you?

I was more asking if recent changes in psalm could cause that other issue?

Not that I know of. Seems like something new, maybe an issue needs to be raised on Psalm repo directly.

Seems Psalm Doctrine plugin now allows Psalm 4, this should be revisited soonish. There's also some indication the plugin might become officially supported by Psalm org and/or fully deprecated because of additions to Doctrine itself, see psalm/psalm-plugin-doctrine#84

@dkarlovi can you rebase when you have few minutes?

Sure, left as TODO, will do it tomorrow. 👍

@jakzal please check now, not happy with the workaround mentioned, maybe you have a better idea?

@dkarlovi since you renamed some tools, can you also regenerate the README with php bin/devkit.php update:readme please?

@jakzal done

@dkarlovi how risky is this change? :)

We have a relatively big change coming in soon (#369), and I'm thinking about how to approach merges and releases. #369 should definitely go in on its own release, and then sit in phpqa's master for a little while before it's tagged in phpqa. I'm wondering if this change should follow a similar process.

@jakzal IMO it's not very risky, the major difference is you now don't have two separate Psalm's (the PHAR which is not capable of using plugins and the one embedded into the doctrine-psalm-plugin namespace which is, but can only see the single plugin).

It will only affect people who currently use the Doctrine plugin in that they'll need to use psalm without the full path, so the migration path is very clear. Everyone else is unaffected.

@jakzal what do you see as the way forward here?

Thank you @dkarlovi 🍺

BTW @jakzal this works, I've tried jakzal/phpqa:alpine just now, it loads the plugins correctly on my test project.